Fix wrong branch name handling fork PR #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
huydhn
changed the title
Signed-off-by: Huy Do <huydhn@gmail.com>
yangw-dev
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way to checkout fork PR from vLLM is to use
refs/pull/PR_NUMBER/head, and as the name implies, the branch name is listed underrefs. This was missed by the upload script, so it couldn't find the correct branch name.Testing
Run one round of benchmark at https://github.com/pytorch/pytorch-integration-testing/actions/runs/16340432143:
refs/pull/20358/headThe results are showing up correctly on the dashboard comparing with the PR base commit. This is also to test vLLM x PyTorch 2.8.0 RC.